v2.4.0: sync parity + colorless job verbs, and dataset snapshot error reporting#40
Open
karaposu wants to merge 3 commits into
Open
v2.4.0: sync parity + colorless job verbs, and dataset snapshot error reporting#40karaposu wants to merge 3 commits into
karaposu wants to merge 3 commits into
Conversation
…one" SnapshotStatus keeps the raw API response and matches more reason keys; download() now reports the reason (or raw) and the snapshot_id.
- SyncBrightDataClient mirrors the async surface: adds `datasets`, the TikTok/YouTube/Reddit/Perplexity/DigiKey scrapers, TikTok/YouTube search verticals, Pinterest trigger/status/fetch, and two Instagram-search methods (profiles, reels_all). - BaseWebScraper and DiscoverService gain id-driven status/wait/fetch/to_result, so a triggered job is drivable without async-only job methods (colorless pattern, like the crawler); existing job methods unchanged. - sync discover_trigger() now returns a colorless DiscoverSnapshot instead of the async-only DiscoverJob. - adds the first synchronous tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes + version bump 2.3.2 → 2.4.0.
SyncBrightDataClientnow mirrors the async surface: addsdatasets, the TikTok/YouTube/Reddit/Perplexity/DigiKey scrapers,TikTok/YouTube search verticals, Pinterest trigger/status/fetch, and two Instagram-search methods (
profiles,reels_all).BaseWebScraper+DiscoverServicegain id-drivenstatus/wait/fetch/to_result— a triggered job is drivable withoutasync-only job methods (colorless pattern, like the crawler); existing job methods unchanged.
Contract note: sync
discover_trigger()now returns a colorlessDiscoverSnapshot(drive viadiscover_status/discover_fetch(task_id)) instead of the async-onlyDiscoverJob, which couldn't be used from sync.Tests