fix: respect BASE_NODE_P2P_ADVERTISE_IP environment variable (#1107)#1137
Open
shinobi133 wants to merge 1 commit into
Open
fix: respect BASE_NODE_P2P_ADVERTISE_IP environment variable (#1107)#1137shinobi133 wants to merge 1 commit into
shinobi133 wants to merge 1 commit into
Conversation
Prevents public IP discovery from overriding an explicitly set BASE_NODE_P2P_ADVERTISE_IP and stops the container from exiting if discovery fails when the IP is already provided.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a bug where
consensus-entrypointcompletely overrides any manually configured public IP and exits if automated discovery fails.Changes
get_public_ipdiscovery logic in a guard check.BASE_NODE_P2P_ADVERTISE_IPenvironment variable.Fixes #1107