fix(ci): surgical catalog edit in publish-catalog.sh (2-line diff)#16
Merged
Conversation
…the whole file Testing publish-catalog.sh against v0.3.0 revealed that the jq re-serialize reformatted UNRELATED entries (e.g. another extension's inline python3 block jq expanded to multi-line) → a noisy diff touching other people's entries. Replaced the jq-rewrite with a surgical Python line-edit anchored on this repo's unique download_url (rewriting only its version + download_url lines), so the catalog PR diff is a clean 2-liner. Verified: diff is exactly 2 lines; re-ran to restore #2952's surgical diff. Keeps the jq presence-guard + JSON validation.
…rchive is HTTP-200 verified The upstream catalog reviewer posts a generic 'verify the tag exists + archive is reachable' advisory on every download_url bump. The script already checks the archive returns 200 before opening the PR, so state that in the PR body — the thread is self-resolving and a maintainer can dismiss the bot comment at a glance. (Can't disable upstream Copilot; this just makes its one benign comment a no-op.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the publish script against v0.3.0 surfaced a real bug: the
jqre-serialize reformatted unrelated catalog entries (jq expands inline objects to its canonical 2-space form), producing a noisy diff that touches other people's entries. Replaced it with a surgical Python line-edit anchored on this repo's globally-uniquedownload_url— rewrites only the entry'sversion+download_urllines.Verified: the diff is now exactly 2 lines; re-running restored catalog PR github/spec-kit#2952 to a clean 2-line diff. shellcheck clean, JSON re-validated, the jq presence-guard kept. The same fix applies to any sibling that copies this script.
🤖 Generated with Claude Code