validate NCName parts of xsd:QName in lexQName#62
Closed
aizu-m wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking how the rich parser turns element text into a QName.
lexQName splits the value at the first colon and keeps everything after it as the local part, but it never checks that the prefix and local part are NCNames. So
p:b:c,b candp:all came back as QNames rather than being rejected as outside the xsd:QName lexical space. The rich parser getQNameValue / getAttributeQNameValue getters are the only callers of this overload, so the bad value flows straight in from untrusted XML.JavaQNameHolder.parse on the validate path already guards both parts with isValidNCName. I added the same two checks to lexQName so it throws InvalidLexicalValueException, which getQNameValue already catches. Leading-colon handling and prefix resolution are unchanged.