Replace O_RDOK with O_RDONLY after alias removal#3566
Merged
Conversation
The O_RDOK/O_WROK aliases have been removed from fcntl.h. Replace all remaining O_RDOK usage with O_RDONLY in the apps repository. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
upstream-oflags
branch
from
a21abcc to
64266c2
Compare
Donny9
approved these changes
Jun 28, 2026
cederom
approved these changes
Jun 28, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @xiaoxiang781216 :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The non-standard
O_RDOK/O_WROKaliases are being removed from NuttX'sinclude/fcntl.h(separate nuttx PR). They were simply aliases forO_RDONLY/O_WRONLY. This change replaces all remainingO_RDOKusage in the apps repository with the standardO_RDONLY.Affected files:
examples/configdata/configdata_main.cnshlib/nsh_script.cplatform/mikroe-stm32f4/mikroe_configdata.cImpact
No functional change.
O_RDOKwas defined asO_RDONLY, so this is a pure text substitution that keeps the same behavior while using the standard POSIX flag name. Safe to merge independently —O_RDONLYis and remains defined in upstream nuttx.Testing
tools/checkpatch.sh -fpasses on all three changed files.