feat(io): add VendedCredentialsProvider for S3 credential refresh#3507
feat(io): add VendedCredentialsProvider for S3 credential refresh#3507gabeiglio wants to merge 2 commits into
Conversation
139d3a1 to
ea0777c
Compare
| Args: | ||
| provider (VendedCredentialsProvider): A concrete type of VendedCredentialsProvider (e.g S3VendedCredentialsProvider) | ||
| """ | ||
|
|
There was a problem hiding this comment.
Can we put a TODO and a pass in here? That should be enough to get rid of the noqa: B027. I believe that will be enough to get rid of that type exception.
I actually have no issues with assigning the provider to an internal variable (that isn't yet used)
| credentials: list[StorageCredential] = Field(alias="storage-credentials") | ||
|
|
||
|
|
||
| class VendedCredentialsProvider: |
There was a problem hiding this comment.
This class seems to be handling two different situations:
- A generic provider for handling vended credentials
- An implementation that handles for S3.
Can we split up the first part into a ABC and then the second part as an implementation?
|
We can reuse the I think it'll be a good idea to keep separate concerns between the Rest Catalog, FileIO, and object storage credentials.
What do you think about this? |
Introduces the credential provider class and the set_credentials_provider hook on the FileIO base class. No FileIO implementation is wired yet.
Rationale for this change
First PR to implement automatic vended credential refresh in PyIceberg.
See epic issue here
Are these changes tested?
Yes, created
test_credentials_provider.pyAre there any user-facing changes?
Yes, users will have support for new config properties like