fix: clone parquet-testing into parquet in verify-release-candidate.sh#1617
Open
adriangb wants to merge 1 commit into
Open
fix: clone parquet-testing into parquet in verify-release-candidate.sh#1617adriangb wants to merge 1 commit into
parquet in verify-release-candidate.sh#1617adriangb wants to merge 1 commit into
Conversation
…verify script `verify-release-candidate.sh` clones the parquet-testing repository into a `parquet-testing` directory, but the git submodule path declared in `.gitmodules` is `parquet`, and every parquet-based test reads its data from `parquet/data/...` (e.g. `python/tests/test_io.py`, `test_store.py`, `test_context.py`). The arrow-testing clone one line above already correctly uses the submodule path (`testing`). This is currently latent because the script's `python3 -m pytest` invocation is commented out, so the wrong directory is never exercised. Fixing the path is a prerequisite for enabling the test run during release verification. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pj5DVU7MaammM2nfHh1ZRG
kosiew
approved these changes
Jun 29, 2026
kosiew
left a comment
kosiew
left a comment
Contributor
There was a problem hiding this comment.
Looks 👍 to me
suggestion:
Since this PR removes the 3.13t wheel,
the description in ..actions/build-wheel/action.yml can be updated to remove 3.13t too
python-tag:
description: "abi3 (covers 3.10..3.14 GIL builds) or a free-threaded interpreter such as 3.13t / 3.14t"
Author
Sorry if I'm missing something: how does this PR remove the 3.13t wheel? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No separate issue. This is a one-line fix to the release verification script, found while manually running the release verification process for 54.0.0-rc2.
Rationale for this change
dev/release/verify-release-candidate.shclones the parquet-testing repository into a directory namedparquet-testing:However, the git submodule path declared in
.gitmodulesisparquet:and the parquet-based tests resolve their data relative to
parquet/data/..., for example:python/tests/test_io.py:read_parquet(path="parquet/data/alltypes_plain.parquet")python/tests/test_store.py:file://{Path.cwd()}/parquet/data/alltypes_plain.parquetpython/tests/test_context.py:parquet/data/alltypes_plain.parquetThe arrow-testing clone on the line immediately above already correctly uses its submodule path (
testing), so the parquet line is an inconsistency.This is currently latent: the script's
python3 -m pytestinvocation is commented out (#TODO: we should really run tests here as well), so the wrong directory is never exercised today. If/when the test run is enabled during release verification, the parquet-reading tests would fail with "No files found ... Cannot infer schema from an empty location". Fixing the clone path is a prerequisite for enabling those tests.What changes are included in this PR?
parquet(instead ofparquet-testing) so it matches the.gitmodulessubmodule path and the paths the test suite expects.Are there any user-facing changes?
No. This only affects the release verification tooling.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pj5DVU7MaammM2nfHh1ZRG