Fix misleading error message when trying to restore and attach volumes from backups#13450
Open
bernardodemarco wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13450 +/- ##
=========================================
Coverage 16.25% 16.26%
- Complexity 13432 13434 +2
=========================================
Files 5667 5667
Lines 500670 500670
Branches 60801 60801
=========================================
+ Hits 81397 81423 +26
+ Misses 410165 410140 -25
+ Partials 9108 9107 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes/improves an error message that is thrown when it is attempted to restore and attach volumes from backups to a target VM that is attached to a backup offering. The message mentions that the target VM has backups, but that is not necessarily true. If they are simply attached to a backup offering, the error message will already be emitted.
I have run into this situation when testing KBOSS (see #12758 (comment)).
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?