Skip to content

Fix: Don't set management server ID if cookie isn't set.#13404

Open
jmgsky wants to merge 1 commit into
apache:4.22from
jmgsky:fix-saml-login-msid-4.22
Open

Fix: Don't set management server ID if cookie isn't set.#13404
jmgsky wants to merge 1 commit into
apache:4.22from
jmgsky:fix-saml-login-msid-4.22

Conversation

@jmgsky

@jmgsky jmgsky commented Jun 11, 2026

Copy link
Copy Markdown

Description

This PR prevents the frontend from setting MS_ID if the "managementserverid" cookie isn't set.

We upgraded to 4.22.1.0 yesterday and non-root-admins couldn't log in with SAML, they were presented with a blank white page and some errors in the javascript console. After a little time in the debugger, I chased it down to this change setting MS_ID in localstorage to "undefined", causing downstream issues in store/modules/user.js.

Fixes: #13277

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Rebuilt the UI and swapped it in place live on our management server.

How did you try to break this feature and the system with this change?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.22.2 milestone Jun 17, 2026
@DaanHoogland DaanHoogland linked an issue Jun 17, 2026 that may be closed by this pull request

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

not tested

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13404 (QA-JID-953)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blank page after SAML user login

4 participants