Fix The PreCommit Python ML tests with ML deps installed job#39007
Fix The PreCommit Python ML tests with ML deps installed job#39007aIbrahiim wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses stability and configuration issues within the Milvus integration tests. By disabling parallel execution (xdist) for specific tests, refining container startup commands, and tuning connection retry parameters, the changes ensure more reliable test outcomes in the CI environment. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request configures Milvus integration tests to run without xdist parallelization, explicitly sets the container command, and reduces the connection retry limits. The review feedback warns that reducing the connection retries to 5 with a flat delay of 2.0 seconds may cause flaky test failures in resource-constrained CI environments and suggests increasing the retries and retaining a backoff factor.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
f3ec9d5 to
64d0c6d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39007 +/- ##
=========================================
Coverage 60.25% 60.25%
Complexity 20572 20572
=========================================
Files 3318 3318
Lines 315452 315485 +33
Branches 17142 17142
=========================================
+ Hits 190073 190104 +31
- Misses 116830 116832 +2
Partials 8549 8549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
claudevdm
left a comment
There was a problem hiding this comment.
Are these milvus tests still running in any of the test suites? Can you confirm?
yes, I checked and they're still running. There are currently two active Milvus integration test files:
Both are marked with @pytest.mark.require_docker_in_docker, and they are included in the PreCommit Python ML workflow and they run on the ubuntu latest runner with Python 3.13 and the failing job is the one that runs apache_beam/ml/ -m require_docker_in_docker, so the Milvus tests are definitely still part of the test suite and that's where the container startup timeout is happening
`WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection ... [attempts 3-21] ... WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection
|
Fixes: #31285
Successful run: https://github.com/apache/beam/actions/runs/27721340857/job/82007252131?pr=39007
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.