Feature/plugin registry cache adjustments#241
Open
graepaul wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the plugin discovery system from standalone functions to a class-based PluginDiscovery architecture with configurable caching and thread-safe class-level cache. Also adds extensive caching infrastructure to PluginRegistry.
Other minor plugin recipe adjustments as well.
Changes
PluginDiscovery Refactoring (nodescraper/pluginrecipe/discovery.py)
Breaking: Converted standalone functions to PluginDiscovery class methods:
<function_name>() → PluginDiscovery().<function_name>()
Has the ability to cache to reduce import times.
Removed from public API:
PluginRegistry Caching (nodescraper/pluginregistry.py)
Added class-level caching infrastructure:
Thread-safe cache access with RLock and double-checked locking
load_plugins_from_entry_points() now returns a copy of cached plugins to prevent corruption
AnalyzerArgs
Changed model_config from dict to ConfigDict(extra="forbid") and removed exclude_none. Now exclude_none is done via
the @model_serializer, since pydantic doesn't support model config with exclude_none.
Fixed error message formatting (string interpolation to f-string)
PluginRunFlags Migration (nodescraper/pluginrecipe/pluginrecipe.py)
Converted from @DataClass(frozen=True) to Pydantic BaseModel with ConfigDict(frozen=True), to be more consistent since we use pydantic elsewhere.
Test Coverage
New: test/functional/test_discovery.py - Comprehensive functional tests for PluginDiscovery: