Fix dashscope structured output#1946
Open
Mozhimomo wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
0cf9f78 to
88303bf
Compare
Contributor
|
Good fix! Setting supportsNativeStructuredOutput to false for DashScope and forwarding ResponseFormat through the tools helper ensures structured output works correctly. The test coverage for the response format forwarding is solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.0-SNAPSHOT
Description
This PR fixes DashScope structured output for calls such as
ReActAgent.call(msgs, MyClass.class, ctx).Previously,
DashScopeChatModeladvertised native structured-output support, soReActAgentselected the nativeresponse_formatpath. However, the DashScope formatter did not mapGenerateOptions.responseFormatintoDashScopeParameters.responseFormat, so the actual DashScope request body did not includeresponse_format. As a result, DashScope could return natural-language text instead of JSON,wrapNativeStructuredResult(...)failed to parse it, andMsg.hasStructuredData()remainedfalse.Changes made:
DashScopeChatModel.supportsNativeStructuredOutput()tofalse, so DashScope structured-output calls use the fallbackgenerate_responsetool path.GenerateOptions.responseFormatmapping inDashScopeToolsHelper.applyOptions(...), so explicit DashScoperesponse_formatoptions are no longer dropped.How to test:
mvn -pl agentscope-core "-Dtest=DashScopeToolsHelperComprehensiveTest,DashScopeChatModelTest" testmvn -pl agentscope-core spotless:checkChecklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)