Add pull request template for improved contribution guidelines#46
Open
RafsanNeloy wants to merge 1 commit into
Open
Add pull request template for improved contribution guidelines#46RafsanNeloy wants to merge 1 commit into
RafsanNeloy wants to merge 1 commit into
Conversation
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
Contributor
|
This is a useful addition and the structure is clear. The branch/test/security checklist plus the test-plan section should make future reviews easier! One small follow-up before we merge: since this is covering plan.md item #13, could you add the remaining CBRAIN-specific quality gates from that item too? In particular, please mention checking JSON/JSONL output modes when command behavior changes, avoiding direct printing from data-layer code, preserving public command compatibility, and that a clean Ruff/pre-commit run is necessary but not enough by itself. Behaviour still needs tests and review. After that, I think this fits the roadmap item well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added general contributor checklist and quality-gate docs which was outlined as task 13 of Phase 2 from
plan.md.