Skip to content

Implement TaylorAxes#743

Merged
cvanelteren merged 9 commits into
mainfrom
feat/taylor-axes
Jun 27, 2026
Merged

Implement TaylorAxes#743
cvanelteren merged 9 commits into
mainfrom
feat/taylor-axes

Conversation

@cvanelteren

@cvanelteren cvanelteren commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Closes #736

This should implement Taylor Axes by deriving from Polar Axes and adding back x/y label support

  • Provide a new derived class TaylorAxes
  • Implement x and y label setters
  • Allow the quadrant to be selected for stylistic purposes
  • Ensure formatting labels make sense
  • test tests tests

@cvanelteren cvanelteren marked this pull request as draft June 23, 2026 11:03
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.21622% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/axes/taylor.py 94.50% 6 Missing and 8 partials ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren marked this pull request as ready for review June 25, 2026 01:08
@cvanelteren

Copy link
Copy Markdown
Collaborator Author

Need to add a few test but otherwise good to go.

@cvanelteren

Copy link
Copy Markdown
Collaborator Author

@kinyatoride can you test this?

@munechika-koyo munechika-koyo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gepcel gepcel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example should be added.

@cvanelteren cvanelteren merged commit 5807902 into main Jun 27, 2026
12 of 13 checks passed
@cvanelteren cvanelteren deleted the feat/taylor-axes branch June 27, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Implement Taylor diagram

3 participants