fix: correct MessageData.get_latency return type annotation (Issue #13)#37
Open
lbedogni wants to merge 5 commits into
Open
fix: correct MessageData.get_latency return type annotation (Issue #13)#37lbedogni wants to merge 5 commits into
lbedogni wants to merge 5 commits into
Conversation
- Added SCIOT-028 for configurable EMA alpha (Issue #9) - Added SCIOT-029 for structured logging (Issue #12) - Added SCIOT-030 for type annotations (Issue #13) - Added missing stories for Issues #3, #6, #10, #11, #16, #19, #21, #23 - Updated SCIOT-026 notes to reference Issue #8 Closes #1 #2 #4 #5 #7 #14 #15 #17 #18 #20 #33 #35 #36
Fixed return type annotation from tuple[float, dict] to float to match actual implementation. Added type-checking tests to verify the annotation and return value consistency. - Fixed type annotation in src/server/communication/message_data.py - Added tests/unit/test_message_data_types.py with 3 verification tests - SCIOT-030 marked as DONE in AGILE_ACTION_PLAN.md
…ccess (SCIOT-040)
…ues #9, #12) - Replace remaining print() calls in http_server.py with logger - Add load_offloading_algo_config() consumer function in request_handler.py - Replace hardcoded alpha=0.5 with configured ema_alpha value - Add test_ema_alpha_configuration_validation test for validation These changes complete SCIOT-041 (ema_alpha configurable) and advance SCIOT-044 (print to logger).
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13 - Corrected return type annotation from tuple[float, dict] to float to match actual implementation.