Add "gamemodes" key value to all entities#328
Conversation
|
You’ll want to add the KV to |
| [ | ||
| gamemode[engine](integer) : "Gamemode" : 0 | ||
| gamemode(choices) : "Gamemode" : 0 = | ||
| gamemodes(flags) : 0 : "Gamemodes" : "Which gamemodes this entity is active in. If no flags are set, the entity is active in all gamemodes." = |
There was a problem hiding this comment.
Srctools needs to have handling of flag names/help text fixed (is it even broken?). There shouldn't be a default value here. I tested this in hammer earlier today and it worked as expected with var(flags) : "Fancy name" : "Desc goes here" =
There was a problem hiding this comment.
Not quite broken, more I don't have them implemented - spawnflags are special-cased, I didn't handle descriptions.
There was a problem hiding this comment.
When I tried mentally to go over the logic in srctools it seemed like it would be able to just handle it as-is, just that stuff would get stored in wrong fields.
There was a problem hiding this comment.
Actually I did implement this but forgot, so we just need the latest srctools.
There was a problem hiding this comment.
I tried updating srctools and removing the : 0 but that just causes the key name to break again (the key name and tab uses the description instead of "Gamemodes").
There was a problem hiding this comment.
I just tried to run this through latest srctools and it errored out because of the default value:
srctools.fgd.FGDParseError: Too many attributes for flags keyvalue!
['0', 'Gamemodes', 'Which gamemodes this entity is active in. If no flags are set, the entity is active in all gamemodes.']
Error occurred on line 5, with file "bases/Gamemodes.fgd".
There was a problem hiding this comment.
Upstream or the strata fork? The latter's quite old... I'll make sure to do some tests tomorrow.
There was a problem hiding this comment.
I guess I used upstream and not the fork. I had a bit of a trouble getting it to run because of getattr check in init.py for some reason.
There was a problem hiding this comment.
It was working as expected with the correct format though.
There was a problem hiding this comment.
I tried updating again and now it's working after removing : 0
Panzerhandschuh
force-pushed
the
feat/gamemode-flags
branch
from
2828199 to
b81f558
Compare
Panzerhandschuh
force-pushed
the
feat/gamemode-flags
branch
from
b81f558 to
eaab915
Compare
3 participants
No description provided.