Persist: index new entity first so circular references don't loop

[Spamercz]

Problem

Persisting a new entity (EmptyElasticId) whose nested elastic entity references it back loops forever. Insert::execute calls PrepareEntityArray::prepare() first, which persists the child; the child's prepare() persists the parent again, and so on. New entities aren't tracked in IdentityMap (their id is the empty string), so isChanged() always reports them as changed and they get re-persisted.

The v2.0 Title/Image fixtures (Title.backdrop → Image, Image.title → Title) are exactly this circular shape.

Change

Insert::execute now saves a new entity in two phases:

1. Index it once with a shallow (all-null) body to obtain its id and register it as persisting in IdentityMap.
2. Prepare/persist its nested entities — a back-reference to the parent now resolves to the parent's id instead of re-persisting it.
3. Re-index it with the full body.

Entities that already have an id are still indexed once (unchanged).

Details

• IdentityMap gains persistingList + markPersisting() / unmarkPersisting() / isPersisting() (and clear() resets it).
• PrepareEntityArray short-circuits to the referenced entity's id (instead of recursing) whenever it isPersisting(), for the nested AbstractElasticEntity, ElasticEntityCollection item, and STIElasticEntity cases. This guard is needed in addition to isChanged() because the parent's serialized hash changes as its children receive ids — so isChanged() alone would still re-enter the loop.
• The shallow first index uses an all-null body (every field except id), which is a valid non-empty document for any mapping; its content is irrelevant because phase 3 overwrites it. Only the second index refreshes, so there is one refresh per entity as before (one extra cheap index call for new entities).

Test

tests/SpameriTests/Elastic/EntityManager/PersistCircularTest.phpt persists a Title whose backdrop is an Image whose title points back at the Title, and asserts: it terminates (no loop), both ids are assigned, the in-memory graph resolves both ids, and each stored document references the other.

$ vendor/bin/tester tests/SpameriTests/Elastic/EntityManager/PersistCircularTest.phpt
OK (1 test)

PHPStan (level 6) and CS are clean on the changed files.

Note: the existing PersistTest/InsertTest are flaky in some environments because their setUp deletes + recreates indexes with a short sleep (and relies on wildcard deletes); the new test avoids this by using auto-create and reading documents back by id. That flakiness is pre-existing and unrelated to this change.

🤖 Generated with Claude Code