Skip to content

WIP: Add RecHit#5

Open
mesmith75 wants to merge 20 commits into
ShipSoft:mainfrom
mesmith75:rec_particle
Open

WIP: Add RecHit#5
mesmith75 wants to merge 20 commits into
ShipSoft:mainfrom
mesmith75:rec_particle

Conversation

@mesmith75

@mesmith75 mesmith75 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Extended particle reconstruction data structure to include hits information.
  • Refactor

    • Updated build configuration and dictionary generation for reconstruction hit components.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@pre-commit-ci[bot], we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 56 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ec4570d9-e2e1-4430-abe4-759c6e8873d1

📥 Commits

Reviewing files that changed from the base of the PR and between ddac47a and 71ab115.

📒 Files selected for processing (2)
  • include/SHiP/RecHit.hpp
  • include/SHiP/RecParticle.hpp
📝 Walkthrough

Walkthrough

RecParticle gains a std::vector<RecHit> hits{} member and includes SHiP/RecHit.hpp. The RecHit.hpp header is registered in the CMake FILE_SET headers and root_generate_dictionary call, and ROOT/Cling dictionary directives for SHiP::RecHit and std::vector<SHiP::RecHit> are added to LinkDef.h.

Changes

RecHit Integration

Layer / File(s) Summary
RecParticle extended with hits member
include/SHiP/RecParticle.hpp
Adds #include "SHiP/RecHit.hpp" and a new std::vector<RecHit> hits{} field to struct RecParticle, with minor formatting adjustments to adjacent energy and time members.
Build and dictionary wiring for RecHit
CMakeLists.txt, include/SHiP/LinkDef.h
RecHit.hpp is added to the SHiPDataModel FILE_SET headers and root_generate_dictionary inputs; LinkDef.h gains #pragma link directives for SHiP::RecHit and std::vector<SHiP::RecHit>.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ShipSoft/data-model#2: Introduces RecParticle with the same CMake/LinkDef/header wiring pattern that this PR extends to add RecHit support.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'WIP: Add RecHit' directly and clearly describes the primary change: introducing a new RecHit class/structure to the codebase, as evidenced by changes across CMakeLists.txt, LinkDef.h, and RecParticle.hpp.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant