ci: use shared release workflow from ShipSoft/.github#39
Conversation
📝 WalkthroughWalkthroughThe ChangesRelease Workflow Delegation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace inline release publishing with a call to the org-level reusable workflow. Behaviour is unchanged: a tag push regenerates release notes via git-cliff and publishes the GitHub Release.
fb515dd to
5f8068f
Compare
|
@coderabbitai rate limit |
|
Your plan includes PR reviews subject to rate limits. More reviews will be available in 37 minutes and 5 seconds. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
13-13: 💤 Low valueConsider pinning to a commit SHA for stronger supply-chain security.
The zizmor tool flags the
@mainbranch reference as unpinned. However, I note that.github/workflows/build-test.ymlalso uses@mainforShipSoft/.githubreusable workflows, so this follows an established repository pattern.For internal org workflows, the risk is lower than for third-party actions. If your team intentionally tracks
mainto pick up shared workflow improvements automatically, this is reasonable. Otherwise, pinning to a specific commit SHA (e.g.,@<sha>) would provide stronger reproducibility and supply-chain guarantees.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yml at line 13, The reusable workflow reference for ShipSoft/.github/.github/workflows/release.yml is currently pinned to `@main`, which is unpinned and poses a supply-chain security risk. Replace the `@main` branch reference with a specific commit SHA (e.g., @<commit-sha>) to ensure reproducibility and stronger security guarantees. This same pattern should also be applied to the ShipSoft/.github reference in .github/workflows/build-test.yml for consistency.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release.yml:
- Line 13: The reusable workflow reference for
ShipSoft/.github/.github/workflows/release.yml is currently pinned to `@main`,
which is unpinned and poses a supply-chain security risk. Replace the `@main`
branch reference with a specific commit SHA (e.g., @<commit-sha>) to ensure
reproducibility and stronger security guarantees. This same pattern should also
be applied to the ShipSoft/.github reference in .github/workflows/build-test.yml
for consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e9002ca9-96bb-4047-9da7-2d20c13baa12
📒 Files selected for processing (1)
.github/workflows/release.yml
Summary
uses:call to the org-level reusable workflow atShipSoft/.github/.github/workflows/release.yml@main.v*tag push regenerates release notes via git-cliff and publishes the GitHub Release.scripts/release.shandcliff.tomlare unchanged — the local release flow stays per-repo.Depends on ShipSoft/.github#4 — merge that first, otherwise the
@mainreference won't resolve.Test plan
scripts/release.sh 0.2.1locally, thengit push --follow-tags origin main.Summary by CodeRabbit