Embrace reentrancy#267
Merged
Merged
Conversation
|
@prokopyl Any reason you are waiting to merge this into master? |
prokopyl
force-pushed
the
embrace-reentrancy
branch
from
405de41 to
770eca8
Compare
Member
Author
This is a breaking change (and a rather major one at that), so it's slated for the next major release of It won't be merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
WindowHandler's methods to be called re-entrantly, which allows for natural platform behavior on Windows and macOS.This is done by changing the
WindowHandlermethods' signatures to only take&selfinstead of&mut self. This makes it so baseview users need to use interior mutability in their types (Cell,OnceCell,RefCell, etc.).While this increases complexity for users, this allows for more granularity in the borrows (rather than
baseviewattempting to prevent reentrancy, and trying to mutably borrow the wholeWindowHandlerfor each event).This also allows for downstream users to perform any kind of action in any kind of handler (e.g. resizing the window on click in a menu), without having to "defer" anything.