Skip to content

Fix col.names="none" suppressing all output when row.names=FALSE #7804

Open
venom1204 wants to merge 1 commit into
masterfrom
issue773355
Open

Fix col.names="none" suppressing all output when row.names=FALSE #7804
venom1204 wants to merge 1 commit into
masterfrom
issue773355

Conversation

@venom1204

Copy link
Copy Markdown
Contributor

closes #7735

the PR fixes a bug where setting col.names="none" combined with row.names=FALSE resulted in zero output.

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (deb9acc) to head (9c8500a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7804   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          87       87           
  Lines       17140    17147    +7     
=======================================
+ Hits        16944    16951    +7     
  Misses        196      196           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@venom1204 venom1204 requested review from joshhwuu and tdhock June 28, 2026 19:39
@github-actions

Copy link
Copy Markdown
  • HEAD=issue773355 much slower for as.data.table.array improved in #7019
  • HEAD=issue773355 much slower for transform improved in #5493
  • HEAD=issue773355 slower P<0.001 for DT[by] max regression fixed in #7480
  • HEAD=issue773355 faster P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 9c8500a

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 26 seconds
Installing different package versions 11 minutes and 44 seconds
Running and plotting the test cases 5 minutes and 29 seconds

@tdhock

tdhock commented Jun 29, 2026

Copy link
Copy Markdown
Member

thanks.
please add NEWs item, and add PR comment which explains behavior before/after this PR?

@tdhock tdhock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

print col.names="none" suppresses print completely

2 participants