fix: replace raise UserWarning with warnings.warn() in verify_report_format (Fixes #8927)#8928
Open
rtmalikian wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughIn Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rmat In monai/auto3dseg/utils.py line 287, was used which raises the warning as an exception, crashing the program. The intent was to emit a warning since the function returns bool to indicate format validity. Replaced with which correctly emits a UserWarning without crashing. Fixes Project-MONAI#8927 Signed-off-by: Raphael Malikian <rtmalikian@gmail.com>
a5dd19e to
9315e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8927
Problem
In
monai/auto3dseg/utils.pyline 287, the code usesraise UserWarning("list length in report_format is not 1"). This raisesUserWarningas an exception, which crashes the program. SinceUserWarninginherits fromWarning → Exception, theraiseworks but terminates execution.The function
verify_report_formatreturnsboolto indicate format validity — a warning is appropriate here, not a fatal exception. Thewarningsmodule is already imported in the file.Solution
Replace
raise UserWarning(...)withwarnings.warn(..., stacklevel=2):Verification
Confirmed that:
raise UserWarning(...)crashes the program (raises as exception)warnings.warn(...)correctly emits aUserWarningwithout crashingwarningsis already imported in the fileAbout the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.
Changelog
Files Changed
monai/auto3dseg/utils.py— Changedraise UserWarning(...)towarnings.warn(...)inverify_report_format()Verification