fix: correct typo in PerceptualLoss MedicalNet warning message (Fixes #8923)#8924
Open
rtmalikian wants to merge 1 commit into
Open
fix: correct typo in PerceptualLoss MedicalNet warning message (Fixes #8923)#8924rtmalikian wants to merge 1 commit into
rtmalikian wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughOne-character typo fix in a warning string inside Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The warning message for MedicalNet channel_wise had 'supp, ort' instead of 'support', making the message confusing for users. Fixes Project-MONAI#8923 Signed-off-by: Raphael Malikian <rtmalikian@gmail.com>
5d8f48c to
5dbb26f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8923
Problem
In
monai/losses/perceptual.pyline 115, the warning message for MedicalNetchannel_wisehas a typo:"MedicalNet networks supp, ort channel-wise loss. Consider setting channel_wise=True."The word "support" is broken by a stray comma and space:
supp, ort→support.Solution
Correct the typo to:
"MedicalNet networks support channel-wise loss. Consider setting channel_wise=True."Verification
$ python3 -c "import ast; ast.parse(open('monai/losses/perceptual.py').read()); print('Syntax OK')" Syntax OKThe fix changes only the warning message string — no logic or behavior is affected.
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.
Changelog
Files Changed
monai/losses/perceptual.py— Fixed typo "supp, ort" → "support" in MedicalNet channel_wise warning messageVerification