strip control characters from printer keywords in ipp backend#1632
Closed
aizu-m wants to merge 1 commit into
Closed
strip control characters from printer keywords in ipp backend#1632aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
michaelrsweet
added a commit
that referenced
this pull request
Jun 29, 2026
…ndatory-job-attributes strings (Issue #1632)
michaelrsweet
added a commit
that referenced
this pull request
Jun 29, 2026
…ndatory-job-attributes strings (Issue #1632)
Member
|
Rather than trying to escape keywords and introduce invalid strings, I'm adding calls to [master 2d3fb86] Make sure we don't report invalid printer-state-reasons or printer-mandatory-job-attributes strings (Issue #1632) [2.4.x a5eea28] Make sure we don't report invalid printer-state-reasons or printer-mandatory-job-attributes strings (Issue #1632) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a malicious ipp printer that puts a newline in a printer-state-reasons or printer-mandatory-job-attributes keyword injects extra STATE:/PPD: lines into the scheduler, so strip control characters in update_reasons and report_printer_state the same way report_attr already does.