DEP: upgrade cibw (4.0.0 -> 4.1.0)#404
Draft
neutrinoceros wants to merge 3 commits into
Draft
Conversation
Contributor
Author
it doesn't. Let's see if I can get pyodide builds by rebasing atop that PR. |
neutrinoceros
force-pushed
the
dep/cibw-4.1
branch
from
53fd75a to
2c60d7b
Compare
This commit adds automatic support for Pyodide/WebAssembly wheels to the
OpenAstronomy publish workflow.
Changes:
- Added 'pyodide' to MACHINE_TYPE dictionary (runs on ubuntu-latest)
- Added get_cibw_platform() function to detect pyodide targets and set
CIBW_PLATFORM environment variable
- Modified get_os() to detect pyodide targets before other platforms
- Updated get_matrix_item() to include CIBW_PLATFORM when needed
- Added CIBW_PLATFORM to the cibuildwheel step in publish.yml
With this change, users can now simply specify:
targets: |
- cp*-pyodide_wasm32
And the workflow will automatically set CIBW_PLATFORM=pyodide without
requiring manual env configuration.
Fixes OpenAstronomy#308
neutrinoceros
force-pushed
the
dep/cibw-4.1
branch
from
2c60d7b to
ef60fe8
Compare
Contributor
Author
|
This now includes a slightly modified version of #345 (I only resolved a merge conflict and apply pre-commit autofixes) |
neutrinoceros
force-pushed
the
dep/cibw-4.1
branch
from
d430d1e to
ef60fe8
Compare
neutrinoceros
commented
Jun 16, 2026
| runs-on: ubuntu-24.04-arm | ||
| - cp313-manylinux_x86_64 | ||
| - target: cp314-pyodide_wasm32 | ||
| runs-on: ubuntu-latest |
Contributor
Author
There was a problem hiding this comment.
Seem to me this line shouldn't be necessary but I empirically found that it was. Probably a defect lurking somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might as well include this too. It might make #345 obsolete.