Report schedule_all start errors#2122
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
exec::schedule_allonstatic_thread_poolso exceptions thrown while preparing item operations are reported withset_error(std::exception_ptr)instead of escaping fromstart().set_nextis allowed to throw, andschedule_alladvertisesset_error(std::exception_ptr), but the previousstart() noexceptimplementation calledset_nextandconnectwithout a catch boundary. The operation now constructs all child operations before starting any of them, catches preparation failures, and sends the current exception to the receiver. It also tracks how many child operations were actually constructed so partially built operations are cleaned up correctly.Testing
cmake --build build --target test.exec./build/test/exec/test.exec "schedule_all on static_thread_pool sends errors from set_next"./build/test/exec/test.exec "[types][static_thread_pool]"ASAN_OPTIONS=abort_on_error=0:symbolize=1 ./build-asan/test/exec/test.exec "schedule_all on static_thread_pool sends errors from set_next"./build/test/exec/test.exec