Fix schedule_all completion for empty ranges#2121
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
exec::schedule_allonstatic_thread_poolso empty ranges complete immediately.countdown_is initialized from the range size. For an empty range, no child operation is started, so nothing decrements the countdown or completes the final receiver. The operation now sendsset_valuedirectly when there are no items to schedule.Testing
cmake --build build --target test.exec./build/test/exec/test.exec "schedule_all on static_thread_pool handles empty ranges"./build/test/exec/test.exec "[types][static_thread_pool]"ASAN_OPTIONS=abort_on_error=0:symbolize=1 ./build-asan/test/exec/test.exec "schedule_all on static_thread_pool handles empty ranges"./build/test/exec/test.exec