Fix schedule_all chunking for small ranges#2120
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
exec::schedule_allonstatic_thread_poolfor small non-empty ranges where the range size is less than the pool thread count.The previous chunk-size calculation could produce
0, which meant the batching loop never advanced. Giving non-empty work a minimum chunk size of1avoids that hard hang. While testing that path, I also found that chunk flushes moved the staged task queue without resettingtasks_size_, so the next flush could try to drain more tasks than were actually queued. The patch resets the staged count after each flush.Testing
cmake --build build --target test.exec./build/test/exec/test.exec "schedule_all on static_thread_pool handles fewer items than threads"./build/test/exec/test.exec "[types][static_thread_pool]"ASAN_OPTIONS=abort_on_error=0:symbolize=1 ./build-asan/test/exec/test.exec "schedule_all on static_thread_pool handles fewer items than threads"./build/test/exec/test.exec