fix(geometry): preserve Angle.angle_value across become()#4853
Open
Chessing234 wants to merge 1 commit into
Open
fix(geometry): preserve Angle.angle_value across become()#4853Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
become() copies points/submobjects but not angle_value, so always_redraw(lambda: Angle(l1, l2)) left get_value() returning the initial angle even after the lines moved. Copy angle_value in an Angle override of become(). Fixes ManimCommunity#4512 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
Angle.get_value()returned the initial angle even after the defining lines moved, when the angle was wrapped inalways_redraw.Cause
always_redraw(lambda: Angle(l1, l2))refreshes the mobject viabecome(), which copies points/submobjects but not the cachedangle_valueattribute thatget_value()returns.Fix
Override
become()onAngleto copyangle_valuefrom the sourceAngle.Testing
Fixes #4512
Made with Cursor