fix(mobject): get_start/get_end fall back to submobject points#4852
Open
Chessing234 wants to merge 1 commit into
Open
fix(mobject): get_start/get_end fall back to submobject points#4852Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
get_start/get_end raised "no points" whenever the top-level mobject had no own points, even though its submobjects did. This breaks e.g. the result of TransformFromCopy(Text(...), circle), whose points end up on submobjects. Fall back to family_members_with_points before erroring. Fixes ManimCommunity#4510 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
get_start()/get_end()raisedCannot call Mobject.get_start for a Mobject with no pointswhenever the top-level mobject had no own points, ignoring points held on submobjects.Cause
The result of
TransformFromCopy(Text(...), circle)(and anyText/Tex-shaped target) keeps its points on submobjects; the top level is empty.get_start/get_endonly looked atself.pointsand errored.Fix
Fall back to
family_members_with_points()(first/last member) before throwing, matching howDashedLinealready resolves start/end.Testing
tests/module/mobject/pass (unrelated typst-binary tests aside).Fixes #4510
Made with Cursor