fix(vmobject): clear error for non-finite points in point_from_proportion#4847
Open
Chessing234 wants to merge 1 commit into
Open
fix(vmobject): clear error for non-finite points in point_from_proportion#4847Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
…tion Functions returning NaN/inf (e.g. a negative base to a fractional power) made every curve length NaN, so the loop fell through to a misleading 'file a bug report' exception. Raise a clear ValueError for non-finite points, and fall back to the last point on float-rounding fallthrough. Fixes ManimCommunity#4838.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Animating along a curve whose function returns NaN/inf (e.g.
MoveAlongPathon aParametricFunctionwith a negative base raised to a fractional power) raises:Non-finite points make every curve length
NaN. BecauseNaNcomparisons are alwaysFalse, the loop inpoint_from_proportionnever returns and falls through to the unreachable 'file a bug report' exception (#4838).Fix
ValueErrortelling the user their function produced NaN/inf.current_lengthjust short oftarget_lengthon the final curve.Closes #4838.