Skip to content

Implement Layer and Wire alignment#1310

Merged
baltzell merged 14 commits into
JeffersonLab:developmentfrom
ftouchte:layer-wire-alignment
Jun 15, 2026
Merged

Implement Layer and Wire alignment#1310
baltzell merged 14 commits into
JeffersonLab:developmentfrom
ftouchte:layer-wire-alignment

Conversation

@ftouchte

@ftouchte ftouchte commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Implement wire and layer alignment

  • Create 2 CCDB tables
  • Make AlertDCFactory to read these tables
  • Store the residual_LR in AHDC::hits, our alignment observable
  • Fix issue: for the AHDC hits the Kalman filter, we should use the non calibrated ADC

Things of particular importance: I have modified the detectorChanged() method in order to load the new tables, is it the right way to do that?

@ftouchte ftouchte added the rg-l label Jun 10, 2026

@mathieuouillon mathieuouillon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in AlertDCWireIdentifier(int,int,int) (File: [AlertDCWireIdentifier.java:34-39]):

public AlertDCWireIdentifier(int _sector, int _layer, int _component) {
        sector = _sector;
        layer = _layer;
        component = _layer;
        num = slc2wire(_sector, _layer, _component);
    }

component is assigned _layer

I can't say if this is correct or not:

    public void detectorChanged(int run) {
        factory = (new AlertDCFactory()).createDetectorCLAS(new DatabaseConstantProvider(run,"default"));
        DatabaseConstantProvider cp = new DatabaseConstantProvider(run, "default");
        cp.loadTable("/geometry/alert/ahdc/layer_alignment");
        cp.loadTable("/geometry/alert/ahdc/wire_alignment");
        AHDCdet = (new AlertDCFactory()).createDetectorCLAS(cp);
    }

I guess @baltzell needs to look into that.

@ftouchte

Copy link
Copy Markdown
Collaborator Author

Thank you @mathieuouillon, I've fixed the bug in the constructor.

@baltzell

Copy link
Copy Markdown
Collaborator

@mathieuouillon this DatabaseConstantProvider initialization paradigm for geometry is around and used in coatjava.

@baltzell baltzell merged commit 2ca6784 into JeffersonLab:development Jun 15, 2026
22 checks passed
@baltzell baltzell added the gemc label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants