Remove in-place modification of shape attribute for numpy.ndarray#2958
Merged
antonwolfy merged 3 commits intoJun 19, 2026
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
remove-in-place-modification-for-numpy.ndarray.shape
branch
from
7a733de to
18d76c2
Compare
Collaborator
|
coverage: 78.091%. remained the same — remove-in-place-modification-for-numpy.ndarray.shape into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_15 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
force-pushed
the
remove-in-place-modification-for-numpy.ndarray.shape
branch
from
f02e5cd to
b3887f1
Compare
antonwolfy
force-pushed
the
remove-in-place-modification-for-numpy.ndarray.shape
branch
from
b3887f1 to
411bee7
Compare
vlad-perevezentsev
approved these changes
Jun 19, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
antonwolfy
deleted the
remove-in-place-modification-for-numpy.ndarray.shape
branch
github-actions Bot
added a commit
that referenced
this pull request
Jun 19, 2026
…#2958) NumPy 2.5 is going to deprecate in-place assignment to `ndarray.shape`. Previously `_as_zero_dim_ndarray` in `dpnp.tensor` relied on this pattern (`view.shape = tuple()`) to turn a size-1 host buffer into a 0-dim array before extracting a Python scalar. This PR replaces it with `reshape(())`, which is the recommended non-deprecated alternative and returns a true 0-dim array. 02beb5c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5 is going to deprecate in-place assignment to
ndarray.shape.Previously
_as_zero_dim_ndarrayindpnp.tensorrelied on this pattern (view.shape = tuple()) to turn a size-1 host buffer into a 0-dim array before extracting a Python scalar.This PR replaces it with
reshape(()), which is the recommended non-deprecated alternative and returns a true0-dim array.