Metric collector v2#286
Open
reggeenr wants to merge 56 commits into
Open
Conversation
norman465
reviewed
Mar 3, 2026
Comment on lines
+410
to
+411
| cpuCurrent := podMetric.Containers[0].Usage.Cpu().ToDec().AsApproximateFloat64() * 1000 | ||
| memoryCurrent := podMetric.Containers[0].Usage.Memory().ToDec().AsApproximateFloat64() / 1000 / 1000 |
Member
There was a problem hiding this comment.
Is Containers[0] guaranteed to be the right container?
Collaborator
Author
There was a problem hiding this comment.
Good point. For apps, jobs yes!
For builds it seems that the larger container appears in the list as the first container.
I will double-check.
norman465
reviewed
Mar 5, 2026
norman465
reviewed
Mar 5, 2026
Co-authored-by: Norman Böwing <9320860+norman465@users.noreply.github.com>
Co-authored-by: Norman Böwing <9320860+norman465@users.noreply.github.com>
norman465
requested changes
Jun 17, 2026
|
|
||
| 1. The metrics collector exposes Prometheus metrics on `localhost:9100/metrics` | ||
| 2. The embedded Prometheus agent scrapes these metrics every 30 seconds | ||
| 3. The agent also discovers and scrapes pods with the `codeengine.cloud.ibm.com/userMetricsScrape: 'true'` annotation |
Member
There was a problem hiding this comment.
I think the agent would discover those pods and scrape additional custom metrics. Default CPU/Memory metrics would be collected for all workload irrespective of that label, right?
| - `eu-de` - EU Central (Frankfurt) | ||
| - `eu-es` - EU Spain (Madrid) | ||
| - `eu-gb` - EU GB (London) | ||
| - `jp-tok` - Japan (Tokyo) |
Member
There was a problem hiding this comment.
Suggested change
| - `jp-tok` - Japan (Tokyo) | |
| - `jp-tok` - Japan (Tokyo) | |
| - `in-che` - India (Chennai) |
| ["eu-de"]="https://eu-de.monitoring.cloud.ibm.com" | ||
| ["eu-es"]="https://eu-es.monitoring.cloud.ibm.com" | ||
| ["eu-gb"]="https://eu-gb.monitoring.cloud.ibm.com" | ||
| ["jp-tok"]="https://jp-tok.monitoring.cloud.ibm.com" |
Member
There was a problem hiding this comment.
Suggested change
| ["jp-tok"]="https://jp-tok.monitoring.cloud.ibm.com" | |
| ["jp-tok"]="https://jp-tok.monitoring.cloud.ibm.com" | |
| ["in-che"]="https://in-che.monitoring.cloud.ibm.com" |
| #!/bin/bash | ||
| set -euxo pipefail | ||
|
|
||
| docker build --platform linux/amd64 . No newline at end of file |
Member
There was a problem hiding this comment.
what is the purpose of this compile & build verify? It's currently not used
Comment on lines
+93
to
+102
| sb.WriteString("# HELP ibm_codeengine_instance_cpu_usage_millicores Current CPU usage in millicores\n") | ||
| sb.WriteString("# TYPE ibm_codeengine_instance_cpu_usage_millicores gauge\n") | ||
| for _, m := range metrics { | ||
| labels := fmt.Sprintf("ibm_codeengine_instance_name=\"%s\",ibm_codeengine_component_type=\"%s\",ibm_codeengine_component_name=\"%s\"", | ||
| escapeLabelValue(m.Name), | ||
| escapeLabelValue(m.ComponentType), | ||
| escapeLabelValue(m.ComponentName)) | ||
| sb.WriteString(fmt.Sprintf("ibm_codeengine_instance_cpu_usage_millicores{%s} %d\n", labels, m.Cpu.Current)) | ||
| } | ||
| sb.WriteString("\n") |
Member
There was a problem hiding this comment.
I would prefer to move those all out so every single type has its own method to have a clean format method that calls them one afther another then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables resource metric integration within Code Engine by running a metrics-collector that emits CPU, and memory usage metrics to IBM Cloud Logs.
Furthermore, this PR contains a dashboard that can be imported into IBM Cloud Monitoring:
On top, this PR demonstrates a away on how Code Engine jobs and apps can emit custom metrics, which are sent to Sysdig
See Readme for further details: https://github.com/IBM/CodeEngine/blob/metric-collector-v2/metrics-collector/README.md
To demonstrate custom metric collection, this PR provides an enrichment of the network-test-app (see readme https://github.com/IBM/CodeEngine/blob/metric-collector-v2/network-test-app/README.md)
