Skip to content

refactor: channel details cleanup#3669

Open
szuperaz wants to merge 9 commits into
developfrom
channel-details-cleanup
Open

refactor: channel details cleanup#3669
szuperaz wants to merge 9 commits into
developfrom
channel-details-cleanup

Conversation

@szuperaz

@szuperaz szuperaz commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🎯 Goal

A cleanup for channel details, the main focus is to make it easier for integrators to reuse the specific building blocks, the implementation details describes all changes in detail,

🛠 Implementation details

  1. Add members button extracted to its own component
    Why? If an integrator wants a separate "list members screen" and want to add "add members" button to the screen, they can reuse <ChannelAddMembersButton > component. The default implementation opens the add member modal, but it's possible to provide onPress for custom navigation.

  2. Move props from ChannelDetails / ChannelDetailsContextProvider to the relevant component-level
    Why? Having all props in a single place is comfortable when using the ChannelDetails component directly, but it's unintuitive when integrators mix and match the building blocks. Now, if someone uses ChannelDetails they can customize the building blocks by overriding them and setting the specific props.

  3. All channel details related components rely on ChannelDetailsContext
    Why? Previously, the ChannelDetails component accepted its own channel prop, but if someone wanted to mix and match building blocks, they needed to use the ChannelDetailsContextProvider. This approach is simpler, because all components rely on the ChannelDetailsContextProvider not almost all.

  4. Simplify contexts for channel edit and add members
    Why? The ChannelAddMembersContext and ChannelDetailsEditContext contain the notification provider too, so if an integrator is building their own screens, they have one less context to provide here.

  5. Some spacing fixes

  6. Fix modal padding on Android in edge-to-edge mode

🎨 UI Changes

No UI changes

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot

Stream-SDK-Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

SDK Size

title develop branch diff status
js_bundle_size 1959 KB 1963 KB +3624 B 🔴

@szuperaz szuperaz changed the title refactor: add members button is a separate component now refactor: channel details cleanup Jun 18, 2026
@szuperaz szuperaz force-pushed the channel-details-cleanup branch from 6be5c58 to f450bcf Compare June 22, 2026 17:28
@szuperaz szuperaz force-pushed the channel-details-cleanup branch from c5bc666 to ec5915d Compare June 22, 2026 19:47
@szuperaz szuperaz marked this pull request as ready for review June 22, 2026 20:04
@szuperaz szuperaz requested a review from isekovanic June 22, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants