Skip to content

Remove flash injection feature#655

Open
planetchili wants to merge 1 commit into
mainfrom
remove/flash-injection
Open

Remove flash injection feature#655
planetchili wants to merge 1 commit into
mainfrom
remove/flash-injection

Conversation

@planetchili

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the “flash injection” feature end-to-end, including the injector binaries/library, kernel-side orchestration, installer packaging, and the UI configuration surface.

Changes:

  • Removed FlashInjector/FlashInjectorLibrary projects from the solution and WiX installer packaging.
  • Removed kernel-side injection plumbing (spec fields, action handling, injector process management, and action client).
  • Removed the UI Flash configuration page and associated preference fields, adding a migration to strip legacy preference keys.

Reviewed changes

Copilot reviewed 73 out of 79 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PresentMon.sln Removes FlashInjector-related projects from the Visual Studio solution.
IntelPresentMon/PMInstaller/PresentMon.wxs Stops installing FlashInjector executables and FlashInjectorLibrary DLLs.
IntelPresentMon/PMInstaller/PMInstaller.wixproj Removes installer project references to FlashInjector projects.
IntelPresentMon/KernelProcess/MakeOverlaySpec.cpp Removes flash injection flag propagation into the kernel overlay spec.
IntelPresentMon/KernelProcess/kact/PushSpecification.h Removes flash injection preferences/serialization and kernel injection update calls.
IntelPresentMon/FlashInjectorLibrary/WrapUtils.h Deletes FlashInjectorLibrary code (wrapping utilities).
IntelPresentMon/FlashInjectorLibrary/WrapUtils.cpp Deletes FlashInjectorLibrary code (wrapping utilities implementation).
IntelPresentMon/FlashInjectorLibrary/resource.h Deletes FlashInjectorLibrary resource header.
IntelPresentMon/FlashInjectorLibrary/NonCopyable.h Deletes FlashInjectorLibrary helper class.
IntelPresentMon/FlashInjectorLibrary/MemoryPool.h Deletes FlashInjectorLibrary memory pool declarations.
IntelPresentMon/FlashInjectorLibrary/MemoryPool.cpp Deletes FlashInjectorLibrary memory pool implementation.
IntelPresentMon/FlashInjectorLibrary/Logging.h Deletes FlashInjectorLibrary logging macros.
IntelPresentMon/FlashInjectorLibrary/Hooks/Hooks.h Deletes FlashInjectorLibrary hook declarations.
IntelPresentMon/FlashInjectorLibrary/Hooks/Hooks.cpp Deletes FlashInjectorLibrary hook implementation.
IntelPresentMon/FlashInjectorLibrary/Hooks/Hooks_DXGI.cpp Deletes DXGI hook implementation used by flash injection overlay.
IntelPresentMon/FlashInjectorLibrary/Hooks/Hooks_D3D11.cpp Deletes D3D11 hook implementation used by flash injection overlay.
IntelPresentMon/FlashInjectorLibrary/Hooks/Hooks_D3D10.cpp Deletes D3D10 hook implementation used by flash injection overlay.
IntelPresentMon/FlashInjectorLibrary/Generated/API_DXGI.h Deletes generated DXGI wrapper definitions.
IntelPresentMon/FlashInjectorLibrary/Generated/API_DXGI_Create_Wrappers.h Deletes generated DXGI wrapper factory declarations.
IntelPresentMon/FlashInjectorLibrary/Generated/API_DXGI_Create_Wrappers.cpp Deletes generated DXGI wrapper factory implementation.
IntelPresentMon/FlashInjectorLibrary/FlashInjectorLibrary.vcxproj.filters Removes FlashInjectorLibrary project filters file.
IntelPresentMon/FlashInjectorLibrary/FlashInjectorLibrary.vcxproj Removes FlashInjectorLibrary project definition.
IntelPresentMon/FlashInjectorLibrary/Extension/Quad.h Deletes shader/quad helper used for injected overlay rendering.
IntelPresentMon/FlashInjectorLibrary/Extension/Quad.cpp Deletes shader/quad helper implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer.h Deletes injected overlay renderer abstraction.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer.cpp Deletes injected overlay renderer base implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D12.h Deletes D3D12 injected overlay renderer.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D12.cpp Deletes D3D12 injected overlay renderer implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D11.h Deletes D3D11 injected overlay renderer.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D11.cpp Deletes D3D11 injected overlay renderer implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D10.h Deletes D3D10 injected overlay renderer.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayRenderer_D3D10.cpp Deletes D3D10 injected overlay renderer implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayConfigPack.h Deletes injected overlay config IPC packing helper.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayConfigPack.cpp Deletes injected overlay config IPC packing helper implementation.
IntelPresentMon/FlashInjectorLibrary/Extension/OverlayConfig.h Deletes injected overlay configuration struct.
IntelPresentMon/FlashInjectorLibrary/Extension/DXGIOverlay.h Deletes DXGI overlay extension wiring for injected rendering.
IntelPresentMon/FlashInjectorLibrary/Extension/DXGIOverlay.cpp Deletes DXGI overlay extension wiring implementation.
IntelPresentMon/FlashInjectorLibrary/DLLMain.cpp Deletes injected DLL entrypoint and action server startup.
IntelPresentMon/FlashInjectorLibrary/Custom/PrePostCalls.h Deletes injected hook pre/post call customization.
IntelPresentMon/FlashInjectorLibrary/Custom/IUnknown_Wrapper.h Deletes COM wrapper interface declarations.
IntelPresentMon/FlashInjectorLibrary/Custom/IUnknown_Wrapper.cpp Deletes COM wrapper implementation.
IntelPresentMon/FlashInjectorLibrary/Custom/Extensions.h Deletes injected extension registration (e.g., swapchain GetBuffer handling).
IntelPresentMon/FlashInjectorLibrary/Custom/API_D3D11.h Deletes generated D3D11 wrapper declarations.
IntelPresentMon/FlashInjectorLibrary/Custom/API_D3D11.cpp Deletes generated D3D11 wrapper implementation.
IntelPresentMon/FlashInjectorLibrary/Context.h Deletes injected library context management.
IntelPresentMon/FlashInjectorLibrary/Context.cpp Deletes injected library context management implementation.
IntelPresentMon/FlashInjectorLibrary/ApiId.h Deletes injected library API id enumeration and linkage.
IntelPresentMon/FlashInjectorLibrary/act/PushConfig.h Deletes injected-library action for pushing overlay config.
IntelPresentMon/FlashInjectorLibrary/act/OpenSession.h Deletes injected-library action for session setup.
IntelPresentMon/FlashInjectorLibrary/act/InjectionPointExecutionContext.h Deletes injected-library symmetric action server context definitions.
IntelPresentMon/FlashInjectorLibrary/act/Common.h Deletes injected-library shared helpers (pipe naming).
IntelPresentMon/FlashInjectorLibrary/act/AllActions.h Deletes injected-library action aggregation header.
IntelPresentMon/FlashInjectorLibrary/act/ActionRegistration.cpp Deletes injected-library action registration TU.
IntelPresentMon/FlashInjector/resource1.h Deletes FlashInjector resource header.
IntelPresentMon/FlashInjector/resource.h Deletes FlashInjector resource header.
IntelPresentMon/FlashInjector/Main.cpp Deletes FlashInjector executable main (process watcher / injector).
IntelPresentMon/FlashInjector/Logging.h Deletes FlashInjector logging macros.
IntelPresentMon/FlashInjector/LibraryInject.h Deletes FlashInjector DLL injection helper declarations.
IntelPresentMon/FlashInjector/LibraryInject.cpp Deletes FlashInjector DLL injection helper implementation.
IntelPresentMon/FlashInjector/FlashInjector.vcxproj.filters Removes FlashInjector project filters file.
IntelPresentMon/FlashInjector/FlashInjector.vcxproj Removes FlashInjector project definition.
IntelPresentMon/FlashInjector/FlashInjector.args.json Deletes FlashInjector debug args configuration.
IntelPresentMon/FlashInjector/CliOptions.h Deletes FlashInjector CLI options definitions.
IntelPresentMon/Core/source/kernel/OverlaySpec.h Removes flash injection field from the kernel overlay specification.
IntelPresentMon/Core/source/kernel/Kernel.h Removes injection-related API and member state from the kernel interface.
IntelPresentMon/Core/source/kernel/Kernel.cpp Removes injection update logic and injector complex construction.
IntelPresentMon/Core/source/kernel/InjectorComplex.h Deletes injector process management implementation (kernel-side).
IntelPresentMon/Core/source/kernel/InjectorComplex.cpp Deletes injector process management implementation (kernel-side).
IntelPresentMon/Core/source/iact/ActionClient.h Deletes core-side injection action client wrapper.
IntelPresentMon/Core/source/iact/ActionClient.cpp Deletes core-side injection action client wrapper implementation.
IntelPresentMon/Core/Core.vcxproj.filters Removes injector/action-client files from Core project filters.
IntelPresentMon/Core/Core.vcxproj Removes injector/action-client compilation units from Core project.
IntelPresentMon/AppCef/ipm-ui-vue/src/views/FlashConfigView.vue Removes the Flash Injection configuration view from the UI.
IntelPresentMon/AppCef/ipm-ui-vue/src/router/index.ts Removes the Flash config route from the Vue router.
IntelPresentMon/AppCef/ipm-ui-vue/src/core/preferences.ts Removes flash injection preferences, bumps prefs version, and adds a migration to delete legacy keys.
IntelPresentMon/AppCef/ipm-ui-vue/src/App.vue Removes Flash config from settings navigation and settings-route detection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants