Moving non-deterministic info line to debug output#1632
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA single logging statement in ChangesLogging and Contributor Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can you please:
|
3a611e7 to
b4581cf
Compare
|
@karabowi done! |
This PR moves the branch-address log from info to debug.
That output includes a raw pointer address, which is not deterministic across runs because it depends on runtime memory layout. Because of that, the logs are not deterministic even when the simulation result is the same. This makes automatic testing by direct log comparison difficult unless the output is cleaned up first.
It also exposes low-level technical detail that is mainly useful for debugging, not for normal simulation logs.
We want to make this change to keep FairShip output cleaner and more deterministic for testing.
Checklist: