Skip to content

Moving non-deterministic info line to debug output#1632

Merged
karabowi merged 2 commits into
FairRootGroup:devfrom
kholoimov:dev_vkholoimov_FairLogger_changes
Jun 18, 2026
Merged

Moving non-deterministic info line to debug output#1632
karabowi merged 2 commits into
FairRootGroup:devfrom
kholoimov:dev_vkholoimov_FairLogger_changes

Conversation

@kholoimov

Copy link
Copy Markdown

This PR moves the branch-address log from info to debug.

That output includes a raw pointer address, which is not deterministic across runs because it depends on runtime memory layout. Because of that, the logs are not deterministic even when the simulation result is the same. This makes automatic testing by direct log comparison difficult unless the output is cleaned up first.
It also exposes low-level technical detail that is mainly useful for debugging, not for normal simulation logs.

We want to make this change to keep FairShip output cleaner and more deterministic for testing.


Checklist:

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8d558291-d8fe-4419-8c36-f6da1c6c1c7a

📥 Commits

Reviewing files that changed from the base of the PR and between 4e38dd3 and b4581cf.

📒 Files selected for processing (2)
  • CONTRIBUTORS
  • fairroot/base/sink/FairRootFileSink.cxx
✅ Files skipped from review due to trivial changes (1)
  • CONTRIBUTORS
🚧 Files skipped from review as they are similar to previous changes (1)
  • fairroot/base/sink/FairRootFileSink.cxx

📝 Walkthrough

Walkthrough

A single logging statement in FairRootFileSink::CreatePersistentBranchesAny is downgraded from info-level to debug-level verbosity during persistent ROOT branch creation. The CONTRIBUTORS file is updated with an additional contributor name.

Changes

Logging and Contributor Updates

Layer / File(s) Summary
Persistent branch creation log level
fairroot/base/sink/FairRootFileSink.cxx
Per-branch log statement for persistent ROOT branch creation downgraded from LOG(info) to LOG(debug).
Contributor list update
CONTRIBUTORS
New contributor name added to the CONTRIBUTORS file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving a non-deterministic log message from info to debug level.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for moving the branch-address log from info to debug level.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@karabowi

Copy link
Copy Markdown
Collaborator

Can you please:

  1. add a separate commit to this PR with your name in the CONTRIBUTORS file?
  2. change the target branch from FairRootGroup:master to FairRootGroup:dev?

@kholoimov kholoimov changed the base branch from master to dev June 17, 2026 08:15
@kholoimov kholoimov force-pushed the dev_vkholoimov_FairLogger_changes branch from 3a611e7 to b4581cf Compare June 17, 2026 08:31
@kholoimov

Copy link
Copy Markdown
Author

@karabowi done!

@karabowi karabowi merged commit 3dc9fdf into FairRootGroup:dev Jun 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants