Skip to content

feat: add dynamic outlined Call to Action buttons #165#167

Open
ahmad1368 wants to merge 4 commits into
stagingfrom
feature/call-to-actions-165
Open

feat: add dynamic outlined Call to Action buttons #165#167
ahmad1368 wants to merge 4 commits into
stagingfrom
feature/call-to-actions-165

Conversation

@ahmad1368

@ahmad1368 ahmad1368 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR introduces three outlined CTA buttons (Sponsors, Speakers, and Volunteers) dynamically rendered below the Hero section. All assets, borders, and text alignment strictly follow the provided design. @vincent6767 please review the changes.

@vincent6767

vincent6767 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
image Hi @ahmad1368, the layout doesn't match the layout I shared in the description. Have you seen the wireframe?

@ahmad1368

Copy link
Copy Markdown
Contributor Author

image Hi @ahmad1368, the layout doesn't match the layout I shared in the description. Have you seen the wireframe?

Hi Vincent,

Thanks for the feedback!

Regarding the layout, Matt specifically requested that the buttons style match the design on awsday.ca. I did my best to replicate that exact aesthetic. I hope I correctly understood which buttons he was referring to, but please let me know if any further tweaks are needed to align with the wireframe.

As for the tests, the unit test file has now been successfully added to the repository (src/components/CallToActions.test.ts) using Vitest to thoroughly verify the button attributes, targets, and links.

Please let me know if you have any other comments!
image

@vincent6767

Copy link
Copy Markdown
Contributor

@ahmad1368 i'm talking about the button position, not the individual button. Have you seen the wireframe I attached in the issue? Matt has agreed to go with that design.

@vincent6767

vincent6767 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@ahmad1368 Please review. I put the button logic in the CallToActions because it promotes modularity and keeps Hero.astro clean. Let me know if you have concerns.

Recording.2026-06-26.021510.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants