Add docker setup#67
Conversation
Sync Develop with main again
…ssing-tests 40 reviewing and adding missing tests
* chore: auto-format to pass CI checks * chore(43): delete create_pr.py Add research for the first forecasting approach for ARGUS market time-series data. Remove out-of-scope PR automation script before merging. --------- Co-authored-by: Lev Gusiev <89646710+BytecodeBrewer@users.noreply.github.com>
Update the contributing
Research database
BytecodeBrewer
added
documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1d4b65980
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Build the Docker image: | ||
|
|
||
| ```bash | ||
| docker build -t argus . |
There was a problem hiding this comment.
In Linux CI/dev environments this command looks for the default file name Dockerfile, but the commit adds the file as lowercase dockerfile; Docker's CLI reference describes --file as the Dockerfile name and says the default is PATH/Dockerfile (https://docs.docker.com/reference/cli/docker/image/build/). Users following this README command will fail before the image builds unless the file is renamed to Dockerfile or the command uses -f dockerfile.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It's just a commit message.
| if result is None: | ||
| return False | ||
|
|
||
| assert result is not None |
There was a problem hiding this comment.
When Yahoo Finance is unavailable, network access is blocked, or yfinance.download returns an empty result, prepare_trend_analysis returns None and this new assertion fails the suite even though the production path handles that case. I checked this test and it does not monkeypatch get_timeseries/yfinance, so CI and the new Docker test image now depend on a live third-party request instead of deterministically exercising the metric logic.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Thx I will change it in the next issue
BytecodeBrewer
removed
documentation
3 participants
ignore