[PWGLF] Nuspex: deuteron proton correlation, add pileup and PID with quadratic cut#16724
Merged
Conversation
ercolessi
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
|
O2 linter results: ❌ 1 errors, |
maciacco
approved these changes
Jun 18, 2026
vkucera
reviewed
Jun 18, 2026
Comment on lines
+73
to
+75
| kPrimary = 0, | ||
| kWeakDecay, | ||
| kMaterial |
vkucera
reviewed
Jun 18, 2026
| if (isTPCPID) { | ||
| if (track.pt() < pTthrpr_TOF) { | ||
| if (!doITSPID || isITSPID) { | ||
| bool isQuadraticPID = TMath::Sqrt(track.tpcNSigmaPr() * track.tpcNSigmaPr() + track.tofNSigmaPr() * track.tofNSigmaPr()) < nsigmaTPC; |
Collaborator
There was a problem hiding this comment.
Don't introduce warnings or errors. Consider using std::hypot instead.
vkucera
reviewed
Jun 18, 2026
Comment on lines
+456
to
+468
| if (sign > 0) { | ||
| if (track.sign() > 0) { | ||
| isProton = true; | ||
| } else if (track.sign() < 0) { | ||
| isProton = false; | ||
| } | ||
| } else if (sign < 0) { | ||
| if (track.sign() > 0) { | ||
| isProton = false; | ||
| } else if (track.sign() < 0) { | ||
| isProton = true; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This seems equivalent to isProton = sign * track.sign() > 0.
vkucera
reviewed
Jun 18, 2026
Comment on lines
+485
to
497
| if (sign > 0) { | ||
| if (track.sign() > 0) { | ||
| isProton = true; | ||
| } else if (track.sign() < 0) { | ||
| isProton = false; | ||
| } | ||
| } else if (sign < 0) { | ||
| if (track.sign() > 0) { | ||
| isProton = false; | ||
| } else if (track.sign() < 0) { | ||
| isProton = true; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
You are duplicating the same block several times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.