Skip to content

[PWGHF] Add new file for Xic correlation#16510

Merged
singhra1994 merged 19 commits into
AliceO2Group:masterfrom
singhra1994:master
Jun 8, 2026
Merged

[PWGHF] Add new file for Xic correlation#16510
singhra1994 merged 19 commits into
AliceO2Group:masterfrom
singhra1994:master

Conversation

@singhra1994

@singhra1994 singhra1994 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwghf PWG-HF label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 2, 2026
Merged
@singhra1994
Merge pull request #49 from alibuild/alibot-cleanup-16510
4c857f9 
Please consider the following formatting changes to AliceO2Group#16510
vkucera
vkucera requested changes Jun 2, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx
Comment on lines +16 to +27
#include "PWGHF/Core/DecayChannels.h"
#include "PWGHF/Core/DecayChannelsLegacy.h"
#include "PWGHF/Core/HfHelper.h"
#include "PWGHF/Core/SelectorCuts.h"
#include "PWGHF/DataModel/AliasTables.h"
#include "PWGHF/DataModel/CandidateReconstructionTables.h"
#include "PWGHF/DataModel/CandidateSelectionTables.h"
#include "PWGHF/DataModel/TrackIndexSkimmingTables.h"
#include "PWGHF/HFC/DataModel/CorrelationTables.h"
#include "PWGHF/HFC/Utils/utilsCorrelations.h"
#include "PWGHF/Utils/utilsAnalysis.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

@vkucera vkucera Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you need all these?

@singhra1994 singhra1994 Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I cross-checked and they are required

@vkucera vkucera Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they are not.

Comment thread PWGHF/HFC/TableProducer/CMakeLists.txt Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
@vkucera vkucera marked this pull request as draft June 2, 2026 16:54
@alibuild alibuild mentioned this pull request Jun 4, 2026
Merged
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/Utils/utilsCorrelations.h Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
vkucera
vkucera reviewed Jun 4, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx
@singhra1994 singhra1994 marked this pull request as ready for review June 4, 2026 16:42
vkucera
vkucera requested changes Jun 5, 2026
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @singhra1994 , thanks for the fixes. Please see a few more suggestions.

Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
@vkucera vkucera changed the title [PWGHF] added new file for Xic correlation [PWGHF] Add new file for Xic correlation Jun 5, 2026
@alibuild alibuild mentioned this pull request Jun 7, 2026
Merged
@singhra1994
Merge pull request #52 from alibuild/alibot-cleanup-16510
f585a02 
[PWGHF] Please consider the following formatting changes to AliceO2Group#16510
vkucera
vkucera approved these changes Jun 8, 2026
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @singhra1994 , looks good to me.

@singhra1994 singhra1994 merged commit ae85138 into AliceO2Group:master Jun 8, 2026
13 of 14 checks passed
fjonasALICE pushed a commit to fjonasALICE/O2Physics that referenced this pull request Jun 9, 2026
@singhra1994 @alibuild @fjonasALICE
[PWGHF] Add new file for Xic correlation (AliceO2Group#16510)
2269428 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@singhra1994 How did you check the includes?

PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx

PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:16:1: warning: included header DecayChannels.h is not used directly [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:18:1: warning: included header HfHelper.h is not used directly [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:19:1: warning: included header SelectorCuts.h is not used directly [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:23:1: warning: included header TrackIndexSkimmingTables.h is not used directly [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:51:1: warning: included header OutputObjHeader.h is not used directly [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:188:145: warning: no header providing "BIT" is directly included [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:652:60: warning: the parameter 'v0' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:667:42: warning: no header providing "std::experimental::is_detected" is directly included [misc-include-cleaner]
PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:1893:36: warning: narrowing conversion from 'Double_t' (aka 'double') to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions]

@vkucera

vkucera commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fix the bug, please.

PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx

PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx:1579:35: style: Iterating over container 'listDaughters' that is always empty. [knownEmptyContainer]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singhra1994 @vkucera @alibuild