sqlalchemy integration does not track all databases

[sk-]

How do you use Sentry?

Sentry Saas (sentry.io)

Version

2.61.1

Steps to Reproduce

When using snowflake-sqlalchemy or clickhouse-sqlalchemy the recorded spans do not include the attribute span.system, which make it difficult to filter the queries.

The only span.system we get is postgresql, which in our case is also used through sqlalchemey (+asyncpg).

Is this a problem on the Sentry side, or is this something that should be fixed by the sqlalchemy extensions (snowflake and clickhouse)?

Expected Result

No span.system is recorded for snowflake or clickhouse.

Actual Result

All queries should include the right system.

[linear-code]

PY-2531

[ericapisani]

Hi @sk- ,

Thanks for opening an issue.

This looks to be a bug on the SDK side rather than the SQLAlchemy extensions. The SDK determines the value to set for the db.system attribute using this method, which is invoked a little further down in that file.

Since snowflake and clickhouse aren't checked or returned in _get_db_system, no value gets set for db.system, which explains the behaviour that you've reported.

If you're feeling up for it, we'd welcome a pull request updating the _get_db_system method to support snowflake and clickhouse - you'd need to follow the pattern already there checking for snowflake or clickhouse in the engine name and returning snowflake or clickhouse respectively.

If you're tight on time/bandwidth, no worries, we've got this issue in our backlog and will pick it up when we have a moment.