From 49281516371f3e9ab944dc0d2cfa36d5eb2fd5db Mon Sep 17 00:00:00 2001 From: Davi Torres <90287660+daviftorres@users.noreply.github.com> Date: Mon, 15 Jun 2026 15:54:05 -0400 Subject: [PATCH 1/4] Suppress errors in disk usage calculation Handle potential errors when calculating disk usage. --- scripts/vm/hypervisor/kvm/nasbackup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vm/hypervisor/kvm/nasbackup.sh b/scripts/vm/hypervisor/kvm/nasbackup.sh index 441312f35e86..86532b138cf2 100755 --- a/scripts/vm/hypervisor/kvm/nasbackup.sh +++ b/scripts/vm/hypervisor/kvm/nasbackup.sh @@ -196,7 +196,7 @@ backup_running_vm() { # Print statistics virsh -c qemu:///system domjobinfo $VM --completed - du -sb $dest | cut -f1 + du -sb $dest 2>/dev/null | cut -f1 || true umount $mount_point rmdir $mount_point From 6e832f1a24d9da2d81916d5c559a1649b541e9cc Mon Sep 17 00:00:00 2001 From: Davi Torres <90287660+daviftorres@users.noreply.github.com> Date: Wed, 17 Jun 2026 09:55:40 -0400 Subject: [PATCH 2/4] Update nasbackup.sh --- scripts/vm/hypervisor/kvm/nasbackup.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/vm/hypervisor/kvm/nasbackup.sh b/scripts/vm/hypervisor/kvm/nasbackup.sh index 86532b138cf2..1b9244ace04f 100755 --- a/scripts/vm/hypervisor/kvm/nasbackup.sh +++ b/scripts/vm/hypervisor/kvm/nasbackup.sh @@ -196,10 +196,10 @@ backup_running_vm() { # Print statistics virsh -c qemu:///system domjobinfo $VM --completed - du -sb $dest 2>/dev/null | cut -f1 || true - - umount $mount_point - rmdir $mount_point + backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true + timeout 60 umount "$mount_point" 2>/dev/null || true + rmdir "$mount_point" 2>/dev/null || true + echo "$backup_size" } backup_stopped_vm() { From 1c0287dc970aeadfe58a9f67034d3a57cbad8524 Mon Sep 17 00:00:00 2001 From: Davi Torres <90287660+daviftorres@users.noreply.github.com> Date: Wed, 17 Jun 2026 09:56:20 -0400 Subject: [PATCH 3/4] Implement timeout for unmounting in nasbackup.sh Add timeout for unmounting backup mount point and cleanup. --- scripts/vm/hypervisor/kvm/nasbackup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/vm/hypervisor/kvm/nasbackup.sh b/scripts/vm/hypervisor/kvm/nasbackup.sh index 1b9244ace04f..0dab7307ced2 100755 --- a/scripts/vm/hypervisor/kvm/nasbackup.sh +++ b/scripts/vm/hypervisor/kvm/nasbackup.sh @@ -197,8 +197,10 @@ backup_running_vm() { # Print statistics virsh -c qemu:///system domjobinfo $VM --completed backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true + timeout 60 umount "$mount_point" 2>/dev/null || true rmdir "$mount_point" 2>/dev/null || true + echo "$backup_size" } From edc80b1ce6b4d47bd4c13680e57348d3fbfd3f95 Mon Sep 17 00:00:00 2001 From: Davi Torres <90287660+daviftorres@users.noreply.github.com> Date: Wed, 17 Jun 2026 14:58:41 -0400 Subject: [PATCH 4/4] Change echo to echo -n for backup size output --- scripts/vm/hypervisor/kvm/nasbackup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vm/hypervisor/kvm/nasbackup.sh b/scripts/vm/hypervisor/kvm/nasbackup.sh index 0dab7307ced2..edff9a2c35e5 100755 --- a/scripts/vm/hypervisor/kvm/nasbackup.sh +++ b/scripts/vm/hypervisor/kvm/nasbackup.sh @@ -201,7 +201,7 @@ backup_running_vm() { timeout 60 umount "$mount_point" 2>/dev/null || true rmdir "$mount_point" 2>/dev/null || true - echo "$backup_size" + echo -n "$backup_size" } backup_stopped_vm() {